Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI by reusing steps #18

Open
PierreZ opened this issue Dec 22, 2021 · 4 comments · May be fixed by #20
Open

Improve CI by reusing steps #18

PierreZ opened this issue Dec 22, 2021 · 4 comments · May be fixed by #20
Assignees
@mohitsaxenaknoldus
Labels
ci Issues related to Github actions good first issue Good for newcomers

Comments

@PierreZ
Copy link
Member

PierreZ commented Dec 22, 2021

Right now, cron-correctness.yml and pr-correctness.yml almost have the same steps runned. The only difference is the number of steps which can be injected as an variable.

It would be nice to import or reuse the steps.
@PierreZ PierreZ added good first issue Good for newcomers ci Issues related to Github actions labels Dec 22, 2021
@mohitsaxenaknoldus
Copy link

Hey, can I work on this?

@PierreZ
Copy link
Member Author

PierreZ commented Dec 27, 2021

Hey @mohitsaxenaknoldus 👋

Yes of course, feel free to open an PR and ask any questions you might have 🚀

@PierreZ
Copy link
Member Author

PierreZ commented Dec 27, 2021

However, we are still impacted by the official FDB site downtime, so all PRs are blocked for now 😞

@mohitsaxenaknoldus mohitsaxenaknoldus linked a pull request Dec 29, 2021 that will close this issue
Open
@mohitsaxenaknoldus
Copy link

@PierreZ PR: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohitsaxenaknoldus mohitsaxenaknoldus

Labels
ci Issues related to Github actions good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse jobs of existing Github Actions Workflow mohitsaxenaknoldus/foundationdb-rs
2 participants
@PierreZ @mohitsaxenaknoldus