Reuse jobs of existing Github Actions Workflow

[mohitsaxenaknoldus]

Fixes #18

[mohitsaxenaknoldus]

@PierreZ can we please run this to see if it's working the right way?

[PierreZ]

Thanks @mohitsaxenaknoldus, this looks really nice, nice work 🥇

I left a couple of comments, mostly in order to split the work, and make the steps useable for other developers and workflows.

Feel free to push some commits 🚀

[PierreZ]

@PierreZ can we please run this to see if it's working the right way?

Unfortunately, I could run it, but it won't work, as we are still impacted by the official FDB site downtime. Downloading FDB from the official website is like the first step for every workflows 😞

I'm checking everyday the relevant issue and also the related posts on the forum, but no ETA for now.

[mohitsaxenaknoldus]

Thanks @mohitsaxenaknoldus, this looks really nice, nice work 🥇

I left a couple of comments, mostly in order to split the work, and make the steps useable for other developers and workflows.

Feel free to push some commits 🚀

Done.
However, I am not aware how those parameters are passed. LMK if I missed something.

[mohitsaxenaknoldus]

@PierreZ can we please run this to see if it's working the right way?

Unfortunately, I could run it, but it won't work, as we are still impacted by the official FDB site downtime. Downloading FDB from the official website is like the first step for every workflows disappointed

I'm checking everyday the relevant issue and also the related posts on the forum, but no ETA for now.

Is it working now?

[PierreZ]

@PierreZ can we please run this to see if it's working the right way?

Unfortunately, I could run it, but it won't work, as we are still impacted by the official FDB site downtime. Downloading FDB from the official website is like the first step for every workflows disappointed
I'm checking everyday the relevant issue and also the related posts on the forum, but no ETA for now.

Is it working now?

Website is up since yesterday, but artifacts have been moved. We are working on publishing a new version for the Github Action. Once this is published, we will merge #19, and everything should work.

I'll run the action once everything is ready. In the mean time, I think you have some indentation errors on your yaml, as Github is not setting some keys in green

[mohitsaxenaknoldus]

@PierreZ can we please run this to see if it's working the right way?

Unfortunately, I could run it, but it won't work, as we are still impacted by the official FDB site downtime. Downloading FDB from the official website is like the first step for every workflows disappointed
I'm checking everyday the relevant issue and also the related posts on the forum, but no ETA for now.

Is it working now?

Website is up since yesterday, but artifacts have been moved. We are working on publishing a new version for the Github Action. Once this is published, we will merge #19, and everything should work.

I'll run the action once everything is ready. In the mean time, I think you have some indentation errors on your yaml, as Github is not setting some keys in green

Should be fixed now, thanks!

[PierreZ]

CI is now fixed, please rebase your PR. I also left some comments.

[coveralls]

Pull Request Test Coverage Report for Build 1802989275

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 201 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+5.02%) to 75.378%

---

Files with Coverage Reduction	New Missed Lines	%
foundationdb/src/tuple/pack.rs	1	92.74%
foundationdb/src/tuple/subspace.rs	1	98.89%
foundationdb/src/transaction.rs	2	88.63%
foundationdb/src/api.rs	6	86.3%
foundationdb/src/tuple/hca.rs	7	67.83%
foundationdb/src/future.rs	31	80.43%
foundationdb-bindingtester/src/main.rs	153	89.69%

Totals
Change from base Build 1701316279:	5.02%
Covered Lines:	4084
Relevant Lines:	5418

---

💛 - Coveralls

[codecov-commenter]

Codecov Report

Merging #20 (d8d99de) into main (d8a388b) will increase coverage by 1.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   81.49%   83.43%   +1.93%     
==========================================
  Files          18       24       +6     
  Lines        3091     4714    +1623     
==========================================
+ Hits         2519     3933    +1414     
- Misses        572      781     +209     

Impacted Files	Coverage Δ
foundationdb/src/future.rs	80.43% <0.00%> (-8.16%)	⬇️
foundationdb-bindingtester/src/main.rs	89.68% <0.00%> (-2.59%)	⬇️
foundationdb/src/lib.rs	100.00% <0.00%> (ø)
foundationdb/src/transaction.rs	88.62% <0.00%> (ø)
foundationdb/src/directory/node.rs	80.95% <0.00%> (ø)
foundationdb/src/directory/error.rs	0.00% <0.00%> (ø)
foundationdb/src/directory/directory_layer.rs	88.79% <0.00%> (ø)
foundationdb/src/directory/directory_partition.rs	81.34% <0.00%> (ø)
foundationdb/src/directory/mod.rs	94.85% <0.00%> (ø)
foundationdb/src/directory/directory_subspace.rs	90.41% <0.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a388b...d8d99de. Read the comment docs.

[PierreZ]

I think something is not working somewhere:

https://github.com/foundationdb-rs/foundationdb-rs/actions/runs/1717931608

error parsing called workflow "foundationdb-rs/foundationdb-rs/.github/workflows/correctness.yml@main": failed to fetch workflow: workflow was not found.

[PierreZ]

error parsing called workflow "foundationdb-rs/foundationdb-rs/.github/workflows/correctness.yml@main": failed to fetch workflow: workflow was not found.

[mohitsaxenaknoldus]

error parsing called workflow "foundationdb-rs/foundationdb-rs/.github/workflows/correctness.yml@main": failed to fetch workflow: workflow was not found.

This is supposed to be the right syntax :/
I am not sure what is wrong.

[PierreZ]

error parsing called workflow "foundationdb-rs/foundationdb-rs/.github/workflows/correctness.yml@main": failed to fetch workflow: workflow was not found.

This is supposed to be the right syntax :/ I am not sure what is wrong.

This is true, the file does not yet exists on the main branch, only on your branch. Maybe you could resolve it locally(i.e in your own branch?)