Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use workspace package property inheritance. #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

waywardmonkeys
Copy link
Contributor

A workspace can contain a workspace.package table to share property values across the crates within a workspace to make it easier to update things.

We now share edition, license, repository, and rust-version across the crates.

A workspace can contain a `workspace.package` table to share
property values across the crates within a workspace to make
it easier to update things.

We now share `edition`, `license,` `repository`, and `rust-version`
across the crates.
@waywardmonkeys
Copy link
Contributor Author

This functionality is described here: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waywardmonkeys
Copy link
Contributor Author

I'll look into the cargo msrv failure.

@PierreZ
Copy link
Member

PierreZ commented Jan 23, 2024

Are you still working on this? Otherwise I will take some time to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants