WIP Alternative breaking PR for versionstamp packing #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a convenience method to support versionstamped keys within a subpsace. This supports any level of the subspace having incomplete versionstamps which are merged when packing new keys and subspaces. It keeps track of the current versionstamp alongside the prefix since we need to know how to adjust the offsets and how many incomplete versionstamps we have.
|
May I close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one takes a more opinionated approach to packing, to ensure that packing of values with incomplete versionstamp will append the versionstamp offset at the end.
To further expand on this, we can expose an enum with
Complete(bytes)andIncomplete(bytes)to force the use withset_versionstampedX