Add multi version support example #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreZ
reviewed
May 20, 2024
| // the cluster. Thus, we catch it by doing a get version request to establish the connection | ||
| // The 3000ms timeout is a guard to avoid waiting forever when the cli cannot talk to any coordinators | ||
| loop { | ||
| let trx = db.create_trx().expect("could not create transaction"); |
There was a problem hiding this comment.
If the first-ever transaction is always failing, I think we can put it before the loop with a expect_err
| // when using external clients, it will throw cluster_version_changed for the first time establish the connection to | ||
| // the cluster. Thus, we catch it by doing a get version request to establish the connection | ||
| // The 3000ms timeout is a guard to avoid waiting forever when the cli cannot talk to any coordinators | ||
| loop { |
There was a problem hiding this comment.
Can you replace the loop with a db.run? Is 1039 retryable?
| } | ||
| break; | ||
| } | ||
| // write initial value |
There was a problem hiding this comment.
I think we can just do a set/get for the test
| @@ -72,7 +72,19 @@ impl FdbApiBuilder { | |||
| self.runtime_version, | |||
| fdb_sys::FDB_API_VERSION as i32, | |||
| ) | |||
| })?; | |||
| }).map_err(|e| { | |||
| // 2203: api_version_not_supported | |||
Pull Request Test Coverage Report for Build 9033137811Details
馃挍 - Coveralls |
|
Could you rebase on branch on main? macos's CI was broken because of #138 |
* Gives an explicit error when the target FoundationDB client version is not supported by the locally installed FoundationDB client lib. Signed-off-by: AlexandreBrg <alexandre.burgoni@clever-cloud.com>
* Creates an example which run a transaction with multiple FoundationDB API Client, allowing to support multiple versions. Signed-off-by: AlexandreBrg <alexandre.burgoni@clever-cloud.com>
alexandrebrg
force-pushed
the
multi_version_example
branch
from
563eebd
to
d8bf3d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢
This PR brings an example of usage for the multi_version feature of FoundationDB library client. Moreover, I added a small error handling when defining the client API version to use. It will help to better understand that the installed lib version is below required rust client version.