Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(foundationdb): Initial commit for tracing support #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PierreZ
Copy link
Member

@PierreZ PierreZ commented Dec 11, 2022

The goal of the PR is to enable some basic tracing capabilities to the foundationdb crate. It is behind a feature not enabled by default.

More tracing operations will be added, once the relevant issue will be fixed

@PierreZ PierreZ marked this pull request as ready for review December 11, 2022 15:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3669655595

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.3%) to 74.189%

Files with Coverage Reduction New Missed Lines %
foundationdb/src/directory/mod.rs 1 94.85%
foundationdb/src/transaction.rs 1 88.39%
foundationdb/src/directory/directory_subspace.rs 2 90.67%
foundationdb/src/directory/directory_layer.rs 8 92.32%
foundationdb/src/directory/directory_partition.rs 8 82.84%
foundationdb-bindingtester/src/main.rs 11 88.71%
Totals Coverage Status
Change from base Build 3669323292: 0.3%
Covered Lines: 4300
Relevant Lines: 5796

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Base: 82.44% // Head: 82.17% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (77aeea6) compared to base (a77116e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   82.44%   82.17%   -0.28%     
==========================================
  Files          26       26              
  Lines        5042     5044       +2     
==========================================
- Hits         4157     4145      -12     
- Misses        885      899      +14     
Impacted Files Coverage Δ
foundationdb/src/database.rs 87.00% <ø> (ø)
foundationdb/src/transaction.rs 88.39% <100.00%> (+0.06%) ⬆️
foundationdb/src/directory/directory_layer.rs 92.32% <0.00%> (-2.03%) ⬇️
foundationdb/src/directory/directory_subspace.rs 90.66% <0.00%> (-1.34%) ⬇️
foundationdb-bindingtester/src/main.rs 88.71% <0.00%> (-1.03%) ⬇️
foundationdb/src/directory/mod.rs 94.85% <0.00%> (+1.47%) ⬆️
foundationdb/src/directory/directory_partition.rs 82.83% <0.00%> (+8.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants