Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: build the docker image for amd64 and arm64 platforms #7512

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Dzejkop
Copy link

@Dzejkop Dzejkop commented Mar 28, 2024

Motivation

Using the docker image (ghcr.io/foundry-rs/foundry) on an Apple Silicon machine runs with the following warning:

 The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

and is likely suffering slowdowns due to emulation.

Solution

This PR should build the images for both amd64 and arm64 platforms

@Dzejkop Dzejkop changed the title Build the docker image for amd64 and arm64 platforms. feat: build the docker image for amd64 and arm64 platforms Mar 28, 2024
@Dzejkop Dzejkop changed the title feat: build the docker image for amd64 and arm64 platforms WIP: feat: build the docker image for amd64 and arm64 platforms Mar 28, 2024
@Dzejkop
Copy link
Author

Dzejkop commented Mar 28, 2024

I'm still waiting for the workflow to pass on my repo https://github.com/Dzejkop/foundry/actions/runs/8467842044/job/23199474123

@DaniPopes DaniPopes requested a review from onbjerg March 29, 2024 04:14
@onbjerg onbjerg marked this pull request as draft March 29, 2024 08:49
@onbjerg
Copy link
Member

onbjerg commented Mar 29, 2024

Marking this as a draft, please move it out of draft once you are ready for reviews :)

@vladislavabramov
Copy link

good lord i need this, the emulation slowdowns have been giving us so much headache lately 😅

@Sn0rt
Copy link

Sn0rt commented May 7, 2024

any update for this PR ?

@onbjerg I have try this PR undery my fork.

I found that I can't move this feature forward. because the release CI need specified runner.

more detail: https://github.com/Sn0rt/foundry/actions/runs/8999845047/job/24722880500

@peterZhang000
Copy link

When will the package succeed, my local package has been compiling for 2 hours now and it's not coming out!

@onbjerg
Copy link
Member

onbjerg commented May 9, 2024

@Sn0rt no update, OP has not circled back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants