-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake support to cpp module #1065
base: main
Are you sure you want to change the base?
Conversation
Filippo Brizzi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PTAL @jtbandes @wkalt @james-rms |
Hi @filippobrizzi, thank you for the contribution! Improved support for our CMake users is important to us. It may be a little while before we get to this, and we appreciate your patience in the meantime. One thing that will be necessary eventually is a CI step. At a high level, we'd like to provide CMake scaffolding for folks to build off of without maintaining something for all architectures and environments. It's possible that we could even migrate from conan to cmake internally if we can do it in a way that doesn't impact existing conan users. Any feedback would be appreciated! |
@@ -71,7 +71,7 @@ test-examples-host: | |||
|
|||
.PHONY: ci-image | |||
ci-image: hdoc-build | |||
docker build -t mcap_cpp_ci -f ci.Dockerfile --build-arg IMAGE=ubuntu:focal --build-arg CC=clang-13 --build-arg CXX=clang++-13 . | |||
docker build -t mcap_cpp_ci -f ci.Dockerfile --build-arg IMAGE=ubuntu:jammy --build-arg CC=clang-13 --build-arg CXX=clang++-13 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using latest ubuntu to get latest cmake version needed to create an interface library
Hi @indirectlylit thanks for the reply.
The only real design choice that I made here for the CMake solution is that |
Thank you @filippobrizzi - iterating on Github CI code can be frustrating and I appreciate the effort! I've created internal tracking issue FG-6815 to make sure this stays on our radar and we'll review asap. |
Public-Facing Changes
None
Description
Add CMake support for the top-level cpp module.
This allows to use mcap in projects that do not support/use conan.
The CMake file generates the install config files that allow running
find_package(mcap)
in external projects.NOTES:
examples/
andtest/
to be part of the global CMake and stop using conan to build them.