Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect "editor.formatOnSave": false #303 #344

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yutotnh
Copy link

@yutotnh yutotnh commented Jul 20, 2023

Summary

The "editor.formatOnSave": false setting is now respected.

"editor.formatOnSave" is now immediately toggled with or without formatting when changed from True to False or False to True.

resolve #303

Problems that were occurring

When VSCode was started with editor.formatOnSave":true and changed to editor.formatOnSave":false, the formatting continued on saving after the change.

When VSCode was restarted, formatting on save was no longer performed.

Ohter

Warning
I tried to debug with the latest commit(5ad70a9), but I got the following error and could not check the operation.
The same error occurs without this change.

Activating extension 'foxundermoon.shell-format' failed: ENOENT: no such file or directory, open '/home/yuto/project/vs-shell-format/dist/one_ini_bg.wasm'.

I made this change to tag 7.2.5 (557f0ac) and it worked.

Changed `editor.formatOnSave` from true to false, but still formatted.
@yutotnh
Copy link
Author

yutotnh commented Jul 21, 2023

In my environment, since commit 2885fbc and its merge commit (f0b43e0) , shell-format has stopped working.

I get the following error message.

image

I made the following changes to 32e6f3c and did yarn install and now shell-format works.

diff --git a/package.json b/package.json
index 9ebc66c..7f70f38 100644
--- a/package.json
+++ b/package.json
@@ -209,7 +209,7 @@
   },
   "dependencies": {
     "diff": "~5.1.0",
-    "editorconfig": "^2.0.0"
+    "editorconfig": "^0.15.3"
   },
   "licenses": [
     {

Sorry if this is a problem specific to my environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"editor.formatOnSave": false doesn't appear to be respected
2 participants