Fix animating from 0 to non-number/pixel keyframe arrays
#1310
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73fe288:
|
mattgperry
force-pushed
the
fix/keyframe-units
branch
from
18a834c
to
f045410
Compare
| @@ -191,6 +183,8 @@ const checkAndConvertChangedValueTypes = ( | |||
| // as it'd be doing multiple resize-remeasure operations. | |||
| if (isKeyframesTarget(to)) { | |||
| const numKeyframes = to.length | |||
| from = to[0] ?? to[1] | |||
There was a problem hiding this comment.
Skimming through the diff, this seems to be the only line that has actually changed, and I don't understand how this change would fix the issue, could you provide additional context?
There was a problem hiding this comment.
If it’s keyframes the “from” value was wrong previously - were actually animating from the values defined here
There was a problem hiding this comment.
Should we update line:189 as well for (let i = to[0] === null ? 1 : 0;. Technically it should always start from the next index we picked up for from right? Can the keyframes array contain undefined?
There was a problem hiding this comment.
The first keyframe can be null, which basically is an instruction to use the current value. But yeah this should be a fromIndex, check out the updated version
mattgperry
force-pushed
the
fix/keyframe-units
branch
from
9791707
to
73fe288
Compare
At some point during Motion 5 we started parsing all
0-unitvalues as0which erroneously failed this check.Fixes #1308