Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing padding from measurement when converting width/height values #1321

Merged
merged 6 commits into from Nov 2, 2021
Merged

Removing padding from measurement when converting width/height values #1321

merged 6 commits into from Nov 2, 2021

Conversation

mattgperry
Copy link
Collaborator

@mattgperry mattgperry commented Nov 1, 2021 •
edited

Fixes #368

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 1, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5032978:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration
framer-motion animatepresence padding issue Issue #368

shuangq
shuangq approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@shuangq shuangq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattgperry mattgperry added the automerge Land this PR label Nov 2, 2021
@mattgperry mattgperry force-pushed the fix/remove-padding-from-height-measurement branch from 9a96087 to 5032978 Compare November 2, 2021 12:06
@mergetron mergetron bot merged commit 9e5ec0c into main Nov 2, 2021
@mergetron mergetron bot deleted the fix/remove-padding-from-height-measurement branch November 2, 2021 12:08
@davidparys
Copy link

davidparys commented Nov 9, 2021 •
edited

Seems that there is still an issue with #368, the element still "snaps" before reaching the end of the animation.

Removing or adding padding, does reduce the snap, but it is still visible

CodeSandbox

@mattgperry mattgperry mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuangq shuangq shuangq approved these changes

Assignees
No one assigned
Labels
automerge Land this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] AnimatePresence height animation with padding doesn't work
3 participants
@mattgperry @davidparys @shuangq