Converting x/y from percent to pixels before drag starts #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3d04eb:
|
nvh
reviewed
Nov 1, 2021
dev/tests/drag.tsx
Outdated
| @@ -2,6 +2,15 @@ import { motion } from "@framer" | |||
| import * as React from "react" | |||
|
|
|||
| // It's important for this test to only trigger a single rerender while dragging (in response to onDragStart) of draggable component. | |||
There was a problem hiding this comment.
Should this comment go below the helper function? Or maybe the helper function should move to the bottom of the file?
nvh
approved these changes
Nov 1, 2021
| } | ||
| } | ||
|
|
||
| this.originPoint[axis] = current as number |
There was a problem hiding this comment.
We could check if it is undefined and not set it otherwise, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424