Allow controls.start() dynamic functions to return variant names
#1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgperry
changed the title
controls.start dynamic functions to return variant namescontrols.start() dynamic functions to return variant names
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9946d69:
|
nvh
reviewed
Nov 2, 2021
Comment on lines
+61
to
+70
| /** | ||
| * If the variant definition is a function, resolve. | ||
| */ | ||
| if (typeof definition === "function") { | ||
| definition = definition( | ||
| custom ?? props.custom, | ||
| currentValues, | ||
| currentVelocity | ||
| ) | ||
| } |
There was a problem hiding this comment.
As this is now in there twice, should we pull it into a resolve function?
There was a problem hiding this comment.
I did think about reducing duplication but if anything we'd probably just be padding out the file given that the only real duplication is the typeof check
There was a problem hiding this comment.
Ah, right, that makes sense.
Well, if you name the function right you wouldn't need the comment and there's the ?? but I see your point.
nvh
approved these changes
Nov 2, 2021
mattgperry
force-pushed
the
fix/dynamic-variant
branch
from
ef0b0f0
to
9946d69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503