Fix HSLA interpolation, add HSLA <-> RGBA animations #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3973ea7:
|
nvh
approved these changes
Nov 3, 2021
| @@ -160,7 +160,7 @@ | |||
| }, | |||
| { | |||
| "path": "./dist/size-webpack-dom-max.js", | |||
| "maxSize": "30.3 kB" | |||
| "maxSize": "30.4 kB" | |||
There was a problem hiding this comment.
Shouldn't these be less tight so that they do not change all the time?
There was a problem hiding this comment.
I'm not so fussed, they're there to be quite strict. It's big enough now that it's easy to forgive what are significant movements, absolutely speaking.
Yeah specifically Popmotion/popmotion@984db89#diff-2b1f8a062fc26f97d539616cb4c033d4b05e5654cff599c8e57e4baa6ed8a375L22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1324
This converts HSLA values to RGBA before animation to move interpolation to linear space, same as RGB. Doing so also enables HSLA <-> RGBA/Hex color interpolation