New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyframe fixes #1355
Keyframe fixes #1355
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 70118d4:
|
src/render/utils/animation-state.ts
Outdated
@@ -201,8 +201,12 @@ export function createAnimationState( | |||
* a changed value or a value that was removed in a higher priority, we set | |||
* this to true and add this prop to the animation list. | |||
*/ | |||
const isVariantChanged = variantsHaveChanged( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe variantDidChange
?
const index = initialAnimationIsBlocked | ||
? valueTarget.length - 1 | ||
: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we take the last element here?
dee62a3
to
5c8a191
Compare
This PR makes a few keyframe fixes:
Fixes #1346
animate
contains keyframes, set the initial value/style to the initial keyframeinitial={false}
andanimate
contains keyframes, set the initial value/style to the final keyframe