Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing at-rest z-index for Reorder.Item to "unset" #1367

Merged
merged 3 commits into from Nov 23, 2021

Conversation

mattgperry
Copy link
Collaborator

Fixes #1313

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7f02309:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration
Framer Motion 5: Drag to reorder lists (forked) Issue #1313

@mattgperry mattgperry added the automerge Land this PR label Nov 23, 2021
@mergetron mergetron bot merged commit 806c6ec into main Nov 23, 2021
@mergetron mergetron bot deleted the fix/reorder-z-index branch November 23, 2021 15:59
@dfelber
Copy link

dfelber commented Apr 2, 2024

FYI: This introduced a rendering bug (Dragged item not always on top) when reordering items.
You can see it even on the official page: https://www.framer.com/motion/reorder/ in the first example. (uses 6.2.8)
https://codesandbox.io/p/sandbox/framer-motion-5-drag-to-reorder-lists-uonye

In the example using drag triggers it behaves correctly (uses 5.0.0-rc.4)
https://codesandbox.io/p/sandbox/framer-motion-5-drag-to-reorder-lists-with-drag-handle-j9enw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Land this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder creates a stacking context which breaks children with a z-index
2 participants