Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inertia: take care of the case when t is zero #2264

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chuganzy
Copy link
Contributor

@chuganzy chuganzy commented Jul 28, 2023

This PR aims to fix an issue where Reorder.Item randomly gets stuck as I posted here.

Related:

As noted here:

requestAnimationFrame timestamps can come through as lower than the startTime

which means that startTime possibly can be equal to currentTime and t is 0 in that case. inertia returns the state with done: true in that case, and stops the animation immediately.

@chuganzy chuganzy changed the title fix Inertia: take care of the case when t is zero fix inertia: take care of the case when t is zero Jul 28, 2023
@mattgperry
Copy link
Collaborator

Is it possible to add a test on inertia for this behaviour?

@chuganzy
Copy link
Contributor Author

chuganzy commented Aug 3, 2023

@mattgperry Thank you for your comment and indeed. Just addressed here. Please let me know!

@ekatzenstein
Copy link

Is there an update on this PR? Having issues with reorders as well

@nick-keller
Copy link

@ekatzenstein their is this PR #2231 waiting to be merged as well

@davisg123
Copy link

Is there anything blocking getting this merged in? It seems like a high impact, edge case fix that includes a test

@nick-keller
Copy link

Shouldn't this be merged? It looks like a very simple fix that is tested. Or maybe I am missing something?

@marwhyte
Copy link

Is there an update on this? I'm also having similar issues with reordering

@bel0v
Copy link

bel0v commented Oct 27, 2023

@mattgperry any chance we could have these 2 PRs merged please? The issue has been affecting our production for a while too

@nick-keller
Copy link

Seeing the recent activity, I am bringing this PR up again! @mattgperry it is the last brik to fix the re-order component that is broken!

@nick-keller
Copy link

Should this PR be merged or closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants