Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add classNames to the default value of callees #262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yuheiy
Copy link

@yuheiy yuheiy commented Jul 17, 2023

add classNames to the default value of callees

Description

The callees in the settings include classnames, but it is classNames that is actually used for the classnames package. Therefore, I added classNames as the default value.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

I applies the callees settings to my project using eslint-plugin-tailwindcss and it worked as intended.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@y-hiraoka
Copy link

@francoismassart
I think this PR is necessary.
@yuheiy, could you please resolve the conflicts?
Alternatively, I can create a new PR from the latest main branch if needed.

@yuheiy
Copy link
Author

yuheiy commented May 20, 2024

@y-hiraoka Thanks, I resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants