Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console errors reporting NaN #417

Open
andrewgoz opened this issue Sep 19, 2023 · 1 comment
Open

Console errors reporting NaN #417

andrewgoz opened this issue Sep 19, 2023 · 1 comment

Comments

@andrewgoz
Copy link

I've found in some cases window.getComputedStyle() is returning empty strings for styles.paddingLeft/Right. The following line:

parseFloat(styles.paddingLeft) + parseFloat(styles.paddingRight);

should probably be changed to something like:

parseFloat(styles.paddingLeft || '0') + parseFloat(styles.paddingRight || '0')
@yunsuklee
Copy link

Hey! Should get fixed with the following PR #418. Hope its usefull.

I also added some element type checking.

@yunsuklee yunsuklee mentioned this issue Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants