Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #417 #418

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #417 #418

wants to merge 2 commits into from

Conversation

yunsuklee
Copy link

@yunsuklee yunsuklee commented Sep 30, 2023 •
edited

Explanation About What Code Achieves:
Screenshots/GIFs:
  • Screenshot
    image
Steps To Test:
  • Wherever function may be used
TODOs:
  • None

@yunsuklee
Refactor getElementContentWidth function
ecebbd5 
- Add error handling for invalid DOM elements
- Provide default values for padding if undefined
@yunsuklee
refactor getElementContentWidth function
33b8448 
- Added error handling for invalid DOM elements.
- Provided default values for padding if undefined or empty.
@yunsuklee yunsuklee changed the title Fix#417 Fix #417 Sep 30, 2023
@yunsuklee yunsuklee mentioned this pull request Sep 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yunsuklee