Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented null value support #243

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

nniclas
Copy link
Contributor

@nniclas nniclas commented Sep 16, 2019

Explanation About What Code Achieves:

Null data support added to line chart
New code renders line paths with gaps using "null" values.

Screenshots/GIFs:

null_data
null_data_regions

Steps To Test:

Add a line chart and set some null values to datasets

TODOs:
  • A simple interpolation is added but not tested fully, can be enabled in AxisChart.js.
  • Null data drawing logics are dependent of the dataset real values, a drawback is they need to be provided through the call chain, some advice is needed if the desire is to make use of the "yPositions" property.
  • Note: some refactoring has been done in draw-utils spline function

@coveralls
Copy link

coveralls commented Sep 17, 2019

Pull Request Test Coverage Report for Build 134

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%

Totals Coverage Status
Change from base Build 133: 0.0%
Covered Lines: 29
Relevant Lines: 62

💛 - Coveralls

@y-nk
Copy link

y-nk commented Sep 20, 2019

Any chance to see that PR merged in a near future ?

@scmmishra
Copy link
Contributor

Is there any generic use-case for such a chart?

@nniclas
Copy link
Contributor Author

nniclas commented Nov 1, 2019

@scmmishra As many other chart libs has this feature I believe it could be a nice addition, however you may just go ahead and close this if it makes sense. 👍

@jakebott
Copy link

jakebott commented Apr 7, 2020

@scmmishra I would also be interested in seeing this pull request merged. We use Frappe charts to plot sensor data, but as the communication to the sensor is not 100% reliable and as a result we occasionally have missed data points - null value support would allow us to show the missing data.

Also as a side note: this would fix #98

@scmmishra scmmishra self-assigned this Apr 7, 2020
@scmmishra scmmishra self-requested a review April 7, 2020 06:14
@scmmishra
Copy link
Contributor

I'll review this and try to get this release soon

@jz222
Copy link

jz222 commented Apr 22, 2020

I would also be happy if this was merged. It would be great to have a general option for line charts to render smooth instead of spiky lines.

@scmmishra
Copy link
Contributor

@nniclas can you complete test interpolate feature? From my testing it seems like its good to merge. Let me know we can enable the option.

@scmmishra scmmishra added this to To do in v2 Oct 1, 2020
@scmmishra scmmishra removed this from To do in v2 Oct 1, 2020
@arthyn
Copy link

arthyn commented Dec 17, 2020

+1 for getting this merged, really like what I see from the library, but it would be nice to be able to pad out the labels

@danekolsen
Copy link

Would love to see this get merged and put out in a new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants