fix: payment term when creating PO from SO #41376
Open
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nihantra-Patel
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
IMS94
reviewed
May 8, 2024
| @@ -1239,11 +1239,18 @@ def set_missing_values(source, target): | |||
| target.discount_amount = 0.0 | |||
| target.inter_company_order_reference = "" | |||
| target.shipping_rule = "" | |||
| target.tc_name = "" | |||
| target.terms = "" | |||
| target.payment_terms_template = "" | |||
There was a problem hiding this comment.
I think the payment_schedule should be cleared. Only clearing the payment_terms_template didn't work for me. The payment_schedule still got copied.
There was a problem hiding this comment.
Only works properly in version 15. I think the issue will be in version 14, but I fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 15 and 14,
fixes: #41369
Before:
before_so_to_po.mp4
After:
after_so_to_po.mp4