feat:Adding Country and State Feilds In Employee Doctype #41379
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
reviewed
May 8, 2024
Comment on lines
827
to
834
| "options": "Country", | ||
| "reqd": 1 | ||
| }, | ||
| { | ||
| "fieldname": "state", | ||
| "fieldtype": "Data", | ||
| "label": "State", | ||
| "mandatory_depends_on": "eval:doc.country==\"United States\"" |
There was a problem hiding this comment.
Suggested change
| "options": "Country", | |
| "reqd": 1 | |
| }, | |
| { | |
| "fieldname": "state", | |
| "fieldtype": "Data", | |
| "label": "State", | |
| "mandatory_depends_on": "eval:doc.country==\"United States\"" | |
| "options": "Country" | |
| }, | |
| { | |
| "fieldname": "state", | |
| "fieldtype": "Data", | |
| "label": "State" |
Remove these reqd checks
There was a problem hiding this comment.
#41392
mam, New PR by removing the reqd checks
There was a problem hiding this comment.
Push it to this branch itself?
There was a problem hiding this comment.
Mam, Pushed to the Same Branch.
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am Working on a US-Payroll App. It Requires a Country and State for Every Employee.
I have added these fields in Employee Doctype in the Address and Contacts Tab and the Address Section. The country is the Link Field to Country Doctype and the state is the Data Field. If the country is equal to the United States, the state will be mandatory as Taxes are calculated based on the state for the "United States" Country