Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sales return issue #41382

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rohitwaghchaure
Copy link
Collaborator

Steps to replicate issue

  • Create Internal Transfer Delivery Note
  • Create Purchase Receipt against the above Internal Transfer Delivery Note
  • Now without creating purchase return entry, try to make Sales Return against the delivery note (created at step 1)
  • System will allow to make Sales Return against the delivery note
  • Ideally system should not allow to make sales return entry and should throw validation.

After Fix
Added validation
Screenshot 2024-05-08 at 5 55 40 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 8, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-delivery-note-return-issue-14523 branch from e380f8e to 9769b26 Compare May 8, 2024 12:40
Copy link

stale bot commented May 25, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant