fix: move renaming of TDS report to [post_model_sync] #41422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename_doc triggers a query on tabDocType.is_virtual, which does not exists [pre_model_sync]
|
Resolved by frappe/frappe#26419 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename_doctriggers a query ontabDocType.is_virtual, which does not exist[pre_model_sync]I added the
merge=Trueparameter to handle the conflict with the new report, which will already exists at the time of the patch.Resolves https://github.com/frappe/erpnext/pull/36196/files#r1597711162