Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SO, DN): only show permitted actions (backport #41384) #41440

Open
wants to merge 2 commits into
base: version-14-hotfix
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 13, 2024

Assume we have a user whose only permission is to read Sales Orders. We shouldn't display all the "Update Items" and "Create ..." buttons, because clicking them will just result in an error message and a frustrating user experience.

Before

All actions are available, regardless of permissions.

Bildschirmfoto 2024-05-08 um 16 21 10

After

Only permitted actions are displayed (none, in this case).

Bildschirmfoto 2024-05-08 um 16 20 45

The same applies to Delivery Note.


This is an automatic backport of pull request #41384 done by Mergify.

(cherry picked from commit c29d955)

# Conflicts:
#	erpnext/selling/doctype/sales_order/sales_order.js
(cherry picked from commit 418bdc1)

# Conflicts:
#	erpnext/stock/doctype/delivery_note/delivery_note.js
Copy link
Contributor Author

mergify bot commented May 13, 2024

Cherry-pick of c29d955 has failed:

On branch mergify/bp/version-14-hotfix/pr-41384
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit c29d955371.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/selling/doctype/sales_order/sales_order.js

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of 418bdc1 has failed:

On branch mergify/bp/version-14-hotfix/pr-41384
Your branch is ahead of 'origin/version-14-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 418bdc1dcc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/public/js/controllers/transaction.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/stock/doctype/delivery_note/delivery_note.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant