fix(AccountsController): Use get_all to get payment requests when updating advance payment status #41443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there was a mistake done in #40643, see diff.
frappe.db.count
was replaced byfrappe.get_list
, which does not have the same permission model (unchecked vs checked)erpnext/erpnext/controllers/accounts_controller.py
Lines 1936 to 1937 in c9c6211
/cc @blaggacao