Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AccountsController): Use get_all to get payment requests when updating advance payment status #41443

Merged

Conversation

cogk
Copy link
Contributor

@cogk cogk commented May 13, 2024

I believe there was a mistake done in #40643, see diff.

frappe.db.count was replaced by frappe.get_list, which does not have the same permission model (unchecked vs checked)

prs = frappe.db.count(
"Payment Request",

/cc @blaggacao

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels May 13, 2024
@blaggacao
Copy link
Contributor

Yep: #40988 should fix it, too. Either way seems good to me.

Thanks for also trying to fix this, @cogk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants