Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: functionality to assign users by user group #26044

Merged
merged 3 commits into from May 14, 2024
Merged

feat: functionality to assign users by user group #26044

merged 3 commits into from May 14, 2024

Conversation

ashish-greycube
Copy link
Contributor

a new functionality to assign users using user group
below is the animated gif showing it in action

@ashish-greycube ashish-greycube requested a review from a team as a code owner April 18, 2024 11:23
@ashish-greycube ashish-greycube requested review from akhilnarang and removed request for a team April 18, 2024 11:23
@Sakshi-Greycube
Copy link

pr

ankush
ankush previously requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ankush ankush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This looks bad in UI, can we keep it single column instead?

frappe/public/js/frappe/form/sidebar/assign_to.js Outdated Show resolved Hide resolved
frappe/public/js/frappe/form/sidebar/assign_to.js Outdated Show resolved Hide resolved
frappe/public/js/frappe/form/sidebar/assign_to.js Outdated Show resolved Hide resolved
@ashish-greycube
Copy link
Contributor Author

image

This looks bad in UI, can we keep it single column instead?
w/o column break , it looks like below..i am not sure, if it looks great

image

@ashish-greycube
Copy link
Contributor Author

all four review comments are done.

@Sakshi-Greycube
Copy link

Sakshi-Greycube commented Apr 24, 2024 •
edited

Below is the new animated gif after fixing 4 review comments:

pr1

@akhilnarang
Copy link
Member

Linter is still failing as code isn't formatted.

https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting

@ashish-greycube
Copy link
Contributor Author

ashish-greycube commented Apr 25, 2024 •
edited

Linter is still failing as code isn't formatted.

https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting

Linter is not failing, i did install that utility
Pl check Details, it says Documentation fail
There is GIF attached with the PR which suffices to explain functionality
@akhilnarang , let me know if i am missing something. thanks

@akhilnarang
Copy link
Member

Linter is still failing as code isn't formatted.
https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting

Linter is not failing, i did install that utility Pl check Details, it says Documentation fail There is GIF attached with the PR which suffices to explain functionality @akhilnarang , let me know if i am missing something. thanks

You can view the linter failure logs here: https://github.com/frappe/frappe/actions/runs/8811181962/job/24184735736?pr=26044

If you installed the pre-commit tool, then you can run pre-commit install, once its setup, it'll automatically run every time you commit in the future.

For now you can run pre-commit run --all-files and it'll format the code as required.

@ashish-greycube
Copy link
Contributor Author

Thanks @akhilnarang for all the help. I think we are good to go now.

@akhilnarang akhilnarang requested a review from ankush April 26, 2024 07:13
@akhilnarang akhilnarang enabled auto-merge (squash) April 26, 2024 07:13
@durve-greycube
Copy link

@ankush , When time permits please review and merge this PR, thanks.

@akhilnarang akhilnarang removed the request for review from ankush May 2, 2024 11:14
@gavindsouza
Copy link
Collaborator

Hey, this is a good-to-have feature. However, it feels weird to have another field for this rather than merging it with the "Assign To" field. Given how mentions are handled in comments - groups only distinguished by the group icon, I would expect the same here too.

@ashish-greycube
Copy link
Contributor Author

@gavindsouza , can it be considered for future enhancement? As i have a cloud customer waiting for this feature. thanks

@durve-greycube
Copy link

@ankush , i have a cloud customer waiting for this feature. Could you please merge it. thanks

@akhilnarang akhilnarang merged commit fdc2bd8 into frappe:develop May 14, 2024
23 of 24 checks passed
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label May 14, 2024
mergify bot pushed a commit that referenced this pull request May 14, 2024
@ashish-greycube @mergify
feat: functionality to assign users by user group (#26044)
08198b5 
* feat: functionality to assign users by user group

* fix: incorporate four comments from review by ankush

* fix: linting issues

(cherry picked from commit fdc2bd8)
@mergify mergify bot mentioned this pull request May 14, 2024
Merged
ankush pushed a commit that referenced this pull request May 14, 2024
@mergify @ashish-greycube
feat: functionality to assign users by user group (#26044) (#26432)
c308931 
* feat: functionality to assign users by user group

* fix: incorporate four comments from review by ankush

* fix: linting issues

(cherry picked from commit fdc2bd8)

Co-authored-by: Ashish Shah <mr.ashish.shah@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 14, 2024
@frappe-bot
chore(release): Bumped to Version 15.27.0
5788621 
# [15.27.0](v15.26.0...v15.27.0) (2024-05-14)

### Bug Fixes

* allow navigating to `Table MultiSelect` fields using tab ([496ae05](496ae05))
* cache github release data per bench (backport [#26382](#26382)) ([#26387](#26387)) ([6e8ef85](6e8ef85))
* **document_follow:** `following` was treated as a string not a boolean ([e0ecfc6](e0ecfc6))
* Increase folder link field size ([#26381](#26381)) ([#26384](#26384)) ([52c335c](52c335c))
* **integrations:** add back `response.raise_for_status()` ([13182e4](13182e4))
* make rename_doc work pre_model_sync ([#26419](#26419)) ([2db51ea](2db51ea))
* pass user and shared params when checking for cache keys ([#26402](#26402)) ([#26404](#26404)) ([a0eb7c1](a0eb7c1))

### Features

* functionality to assign users by user group ([#26044](#26044)) ([#26432](#26432)) ([c308931](c308931))

### Performance Improvements

* Don't update session in cache after every request ([#26308](#26308)) ([#26362](#26362)) ([c0ba12c](c0ba12c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilnarang akhilnarang akhilnarang approved these changes

@ankush ankush ankush left review comments

Assignees
No one assigned
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ashish-greycube @Sakshi-Greycube @akhilnarang @durve-greycube @gavindsouza @ankush