Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in_reply_to #26307

Closed
wants to merge 2 commits into from
Closed

fix: in_reply_to #26307

wants to merge 2 commits into from

Conversation

ankush
Copy link
Member

@ankush ankush commented May 2, 2024

  1. Communication composer UI will remember message ID of parent email for replies and send it as in_reply_to to frappe.sendmail.

  2. Fixes invalid header:

3.6.4 - Identification fields

in-reply-to     =       "In-Reply-To:" 1*msg-id CRLF
msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]

ref: https://www.ietf.org/rfc/rfc2822.txt

TODO:

  • test it out on real servers.

ankush added 2 commits May 2, 2024 19:27
https://www.ietf.org/rfc/rfc2822.txt

3.6.4 - Identification fields

```
in-reply-to     =       "In-Reply-To:" 1*msg-id CRLF
msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]
```
@ankush ankush requested a review from a team as a code owner May 2, 2024 14:22
@ankush ankush requested review from akhilnarang and removed request for a team May 2, 2024 14:22
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label May 2, 2024
@ankush ankush marked this pull request as draft May 2, 2024 15:06
Copy link

stale bot commented May 18, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 18, 2024
@stale stale bot closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-test-cases Add test case to validate fix or enhancement inactive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant