perf: cache site config for ~5 minutes #26341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Possibly Breaking * On typical requests like `get_list` just computing site config takes 4% of time. This is mostly 2 `open` calls and 2 `json.loads` calls. This allows realtime config updates but who really needs this? Most web services I know read config once at startup and never again. Caching 5 minutes is middle ground between old behaviour and some perf benefits.
github-actions
bot
added
the
add-test-cases
|
This is failing, can just wipe site config cache when set-config is called? |
|
@akhilnarang yeah that works for single process only. Figuring out some way to signal all running processes to reload their cached site configs 😄 |
Ah yeah was only thinking about redis🙈 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* Possibly Breaking *
On typical requests like
get_listjust computing site config takes 4%of time. This is mostly 2
opencalls and 2json.loadscalls.This allows realtime config updates but who really needs this? Most web
services I know read config once at startup and never again. They either
ask you to restart or have
reloadsignal for reloading configuration.Caching 5 minutes is middle ground between old behaviour and some perf
benefits.