fix: 🐛 allow insert/save when doc contains a virtual link field #26365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting of properties without a setter (in case of virtual fields) just doesn't work and makes no sense anyway
github-actions
bot
added
the
add-test-cases
|
@ankush Any chance to get this into the next version-14 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a virtual link field prohibits docs from being inserted/saved.
You will get the exception
instead.
Setting of properties without a setter (in case of virtual fields) just doesn't work and makes no sense anyway.
Due to this, this PR skips setting these fields.
Please backport this to version-14 and version-15.