feat(RQ Job): Extended List capabilities & re-enqueue #26368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
gavindsouza
commented
May 7, 2024
gavindsouza
force-pushed
the
rq_job-fix-001
branch
from
c1fe821
to
5a3607b
Compare
gavindsouza
removed
the
add-test-cases
ankush
requested changes
May 13, 2024
| order_desc = "desc" in order_by | ||
| return sorted(jobs, key=lambda j: j.creation, reverse=order_desc) | ||
| sort_comparator = partial(rq_comparator, sort_key=sort_key) | ||
| sorted_jobs = sorted(jobs, key=sort_comparator, reverse=order_desc)[start : start + page_length] |
There was a problem hiding this comment.
This was deliberately not implemented. If you have 1000s of jobs this will serialize all of them. This is what used to break bench doctor completely (probably still does)
We can't have diagnostics tools fail to load, that defeats the whole purpose.
Some alternate hack for paging can be based on sorted job names maybe (?)
There was a problem hiding this comment.
Previous background jobs page also used to do this, just keeping that page open would bring the site down because it was serializing all jobs every 5 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes