refactor: AssignmentRule.apply #26371
Draft
+112
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enqueue notifications in bulk rather than individually.
github-actions
bot
added
the
add-test-cases
- Add typing hints to APIs - Pass doc as kwarg in assign_to.add to bypass re-fetching - Remove redundant code blocks (add_column _assign, extra error handling) - Use caches whenever available, and less expensive condition eval order
gavindsouza
force-pushed
the
perf-assignment_rule
branch
from
4f84882
to
97a6b12
Compare
gavindsouza
force-pushed
the
perf-assignment_rule
branch
from
888e858
to
be54e6f
Compare
gavindsouza
removed
the
add-test-cases
ankush
reviewed
May 15, 2024
| @@ -292,6 +292,7 @@ def init(site: str, sites_path: str = ".", new_site: bool = False, force=False) | |||
| local.role_permissions = {} | |||
| local.valid_columns = {} | |||
| local.new_doc_templates = {} | |||
| local.system_notifications_queue = [] | |||
There was a problem hiding this comment.
can't this just be part of enqueue to flush after commit?
It implements same exact behavior:
- Queue till commit
- flush after commit
- clear queue in case of rollback or no commit
ankush
reviewed
May 15, 2024
| make_notification_log(doc, users) | ||
| else: | ||
| frappe.local.system_notifications_queue.append((doc, users)) | ||
| if flush_system_notifications not in frappe.db.after_commit._functions: |
There was a problem hiding this comment.
Suggested change
| if flush_system_notifications not in frappe.db.after_commit._functions: | |
| if not frappe.local.system_notifications_queue: |
Can do this instead of relying on internal attribute. Line will have to move up before append.
There was a problem hiding this comment.
This pattern is very common though, maybe we should have deduplicate or once flag on callback manager 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
_assignin tables