Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(nightlife example app): Create an example of the nightlife take home project #422

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GJStathis
Copy link

Checklist:

Closes #48950

Creation of nightlife take home project to use as example for coding interview prep section of website here

App implements all listed user stories.

One thing of note. I am not sure if the mobile view of the app is perfect. I did not know if I needed to optimize for all potential screens for this example or just desktop.

Finally, I do not know what the steps are to deploy this app past making this PR. Any help is appreciated.

Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there,

Thank you for taking the time to contribute.

We cannot accept this PR as is for a few reasons:

  1. The rollup config does not work
  • It points to a file that does not exist
  1. The styling of the app does not fit the https://design-style-guide.freecodecamp.org/
  • At the very least it should match the example video in the issue discussions

If you still want to work on this, let us know. Otherwise, someone else can take over this PR, or we can open a new one.

Thanks again 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants