Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cash-register)-Fixed floating point bug on checkCashRegister function #560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obafemitayor
Copy link

@obafemitayor obafemitayor commented Dec 31, 2023

This PR fixed the floating point bug reported in this issue.

Testing Strategy
https://www.loom.com/share/b4267e70f93442ea91c182710eb68d95

Checklist:

Closes #559

@obafemitayor obafemitayor changed the title fix(cash-register)-Fixed floating point bug fix(cash-register)-Fixed floating point bug on checkCashRegister function Dec 31, 2023
@obafemitayor obafemitayor marked this pull request as ready for review December 31, 2023 04:01
@obafemitayor obafemitayor requested a review from a team as a code owner December 31, 2023 04:01
@obafemitayor
Copy link
Author

@gikf Could you help review this PR if you have the chance please?

@camperbot
Copy link

We realize you're looking to get help as soon as possible. Rather than pinging someone directly, which can be considered rude, would you mind joining our Discord and asking your question there? Someone might be more readily available to help.

@naomi-lgbt naomi-lgbt self-requested a review January 9, 2024 19:08
@naomi-lgbt naomi-lgbt self-assigned this Jan 9, 2024
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It looks like the issue in the result object is still present.

@a2937
Copy link
Member

a2937 commented Jan 20, 2024

Hi there. I think you should look at making sure the numbers that are displayed have a fixed number of digits.

Lastly to solve the negative coins in the drawer, maybe you should check to see if there's actually the proper amount of change in the drawer before you remove the coin. Like if there's actually a penny or dime, or if there's only a weird tiny spec that seems to registering as a little more than worthless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cash Register Demo - floating-point error
4 participants