fix: no negative currency cash register #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gikf
approved these changes
Feb 6, 2024
gikf
reviewed
Feb 6, 2024
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
|
Is there still a merge conflict on this PR? |
|
I linted the file so this can finally be merged. |
naomi-lgbt
requested changes
Apr 2, 2024
There was a problem hiding this comment.
Unfortunately this introduces a regression - the final test no longer passes for the demo project with these changes (there's likely an off-by-one error going on somewhere).
It may be beneficial to refactor the project to handle all of the math with cents as the base instead of dollars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #559