Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js and likes #44097

Merged
merged 4 commits into from Nov 3, 2021
Merged

Upgrade Node.js and likes #44097

merged 4 commits into from Nov 3, 2021

Conversation

raisedadead
Copy link
Member

@raisedadead raisedadead commented Nov 2, 2021

Rebase merge

@gitpod-io
Copy link

gitpod-io bot commented Nov 2, 2021

@github-actions github-actions bot added platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Nov 2, 2021
@ghost

This comment has been minimized.

@github-actions github-actions bot added the scope: docs Codebase and other documentation label Nov 2, 2021
@raisedadead raisedadead marked this pull request as ready for review November 2, 2021 17:37
@raisedadead raisedadead requested a review from a team as a code owner November 2, 2021 17:37
@raisedadead raisedadead enabled auto-merge (rebase) November 2, 2021 17:37
@ShaunSHamilton
Copy link
Member

This looks to work 👍

I do get this error in the client:

Error
 ERROR 

(node:2531) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./"
in the "exports" field module resolution of the package at
/workspace/freeCodeCamp/client/node_modules/chai/package.json.
Update this package.json to use a subpath pattern like "./*".
(Use `node --trace-deprecation ...` to show where the warning was created)

But, this should be resolved with: chaijs/chai#1400


Probably unrelated, but Gitpod at least uses this for some reason:

MongoDB shell version v5.0.2

Locally, it is 4.2. So, something to keep in mind.


Otherwise, I have been using node@16 for over one week, and have not come across any issues.

@naomi-lgbt
Copy link
Member

I get the deprecated folder mapping on Node 14 too.

@naomi-lgbt
Copy link
Member

image

I run npm install and it looks like our root package-lock is a bit out of sync. @raisedadead do you want me to push up a commit? It's only 43 lines of change.

@raisedadead
Copy link
Member Author

Yeah - some dependencies were updated in some of these packages while this PR is awaiting a merge and I have just rebased and updated all the lockfiles including the root, client, tools, etc.

Thanks for your review Nick and Shaun. I am going to wait for the tests and merge this in.

@raisedadead raisedadead merged commit a971126 into main Nov 3, 2021
@raisedadead raisedadead deleted the chore/update-node branch November 3, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: docs Codebase and other documentation scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants