This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
Switch to poetry for dependency management
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloquence
commented
Jan 20, 2023
| ./.venv/bin/pip install --require-hashes -r requirements/requirements.txt | ||
| apt-get update && apt-get install -y --no-install-recommends make python3 python3-pip | ||
| pip install poetry | ||
| poetry install --no-ansi |
There was a problem hiding this comment.
The --no-ansi argument is necessary due to a bug in CircleCI: python-poetry/poetry#7184 (and harmless once that bug is fixed).
eloquence
commented
Jan 20, 2023
eloquence
commented
Jan 20, 2023
eloquence
force-pushed
the
switch-to-poetry
branch
2 times, most recently
from
f4692d0
to
2ba850b
Compare
eloquence
force-pushed
the
switch-to-poetry
branch
from
2ba850b
to
599c26b
Compare
legoktm
suggested changes
Feb 22, 2023
There was a problem hiding this comment.
Overall looks good, minor notes in the deploy/Dockerfile.
One thing I ran into is that the poetry package provided by Fedora is out of date and doesn't support the poetry lock-version = "2.0" that the latest one generates. Not an issue, just noting that we'll all have to manually install poetry instead of being able to use system packages.
deploy/Dockerfile
Outdated
|
|
||
| ARG GIT_BRANCH=main | ||
| RUN apt-get -q update && apt-get -qy upgrade && apt-get -qy install git make latexmk texlive-latex-extra | ||
| COPY ./ . | ||
| RUN pip install -r requirements/requirements.txt | ||
| RUN pip install --upgrade pip | ||
| RUN pip install poetry |
eloquence
force-pushed
the
switch-to-poetry
branch
from
81c2260
to
febcfe3
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our dependency management tooling for this repository from
pipandpip-compileto poetry. We've previously discussed use ofpoetryinsecuredrop-clienthere: freedomofpress/securedrop-client#1278. We're also already using it for Dangerzone (https://github.com/freedomofpress/dangerzone).poetryuses a modern lockfile strategy, flexible version range specifiers, and provides informative output in cases of dependency resolution issues.This repository represents a small and simple enough target that it felt like a good place to experiment with this tooling for local development, CI and deployment.