Add PlantUml Plugin #551

larsgrefer · 2022-06-17T15:27:31Z

No description provided.

sonatype-lift · 2022-06-17T15:37:01Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlTask.java

+    @OutputDirectory
+    private final DirectoryProperty outputDirectory = getProject().getObjects().directoryProperty();
+
+    @Getter


SameNameButDifferent: The name @Getter refers to [java.lang.SuppressWarnings, lombok.Generated, org.gradle.api.file.ConfigurableFileCollection, org.gradle.api.file.DirectoryProperty, org.gradle.api.provider.Property, java.lang.String, java.lang.Boolean] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-06-17T15:37:02Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlParameters.java

+import org.gradle.workers.WorkParameters;
+
+/**
+ * @author Lars Grefer


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T15:37:03Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlPlugin.java

+import org.gradle.api.artifacts.Configuration;
+
+/**
+ * @author Lars Grefer


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T15:37:05Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlAction.java

+ */
+public abstract class PlantumlAction implements WorkAction<PlantumlParameters> {
+
+    @SneakyThrows


SameNameButDifferent: The name @SneakyThrows refers to [java.lang.Throwable, lombok.Lombok] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-06-17T15:37:06Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlTask.java

+    @Classpath
+    private final ConfigurableFileCollection plantumlClasspath = getProject().files();
+
+    @Getter


SameNameButDifferent: The name @Getter refers to [java.lang.SuppressWarnings, lombok.Generated, org.gradle.api.file.ConfigurableFileCollection, org.gradle.api.file.DirectoryProperty, org.gradle.api.provider.Property, java.lang.String, java.lang.Boolean] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-06-17T15:37:07Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlTask.java

+
+    private final WorkerExecutor workerExecutor;
+
+    @Getter


SameNameButDifferent: The name @Getter refers to [java.lang.SuppressWarnings, lombok.Generated, org.gradle.api.file.ConfigurableFileCollection, org.gradle.api.file.DirectoryProperty, org.gradle.api.provider.Property, java.lang.String, java.lang.Boolean] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-06-17T15:37:09Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlAction.java

+import org.gradle.workers.WorkAction;
+
+/**
+ * @author Lars Grefer


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T15:37:10Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlTask.java

+import java.io.File;
+
+/**
+ * @author Lars Grefer


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T15:37:12Z

plantuml-plugin/src/main/java/io/freefair/gradle/plugins/plantuml/PlantumlTask.java

+    @Input
+    private final Property<String> fileFormat = getProject().getObjects().property(String.class).convention("SVG");
+
+    @Getter


SameNameButDifferent: The name @Getter refers to [java.lang.SuppressWarnings, lombok.Generated, org.gradle.api.file.ConfigurableFileCollection, org.gradle.api.file.DirectoryProperty, org.gradle.api.provider.Property, java.lang.String, java.lang.Boolean] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

codecov · 2022-06-17T17:16:44Z

Codecov Report

Merging #551 (9b3e49b) into master (216e7b7) will increase coverage by 1.23%.
The diff coverage is 88.88%.

❗ Current head 9b3e49b differs from pull request most recent head 4a5ac9d. Consider uploading reports for the commit 4a5ac9d to get more accurate results

@@             Coverage Diff              @@
##             master     #551      +/-   ##
============================================
+ Coverage     31.17%   32.41%   +1.23%     
- Complexity      209      221      +12     
============================================
  Files           104      107       +3     
  Lines          2784     2838      +54     
  Branches        255      255              
============================================
+ Hits            868      920      +52     
+ Misses         1840     1837       -3     
- Partials         76       81       +5

Impacted Files	Coverage Δ
...eefair/gradle/plugins/plantuml/PlantumlPlugin.java	`84.61% <84.61%> (ø)`
...freefair/gradle/plugins/plantuml/PlantumlTask.java	`86.20% <86.20%> (ø)`
...eefair/gradle/plugins/plantuml/PlantumlAction.java	`100.00% <100.00%> (ø)`
.../freefair/gradle/plugins/git/GitVersionPlugin.java	`33.33% <0.00%> (+3.92%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216e7b7...4a5ac9d. Read the comment docs.

… into feature/plantuml

Add PlantUml Plugin

cd36602

larsgrefer added the enhancement label Jun 17, 2022

larsgrefer requested a review from Frisch12 June 17, 2022 15:27

larsgrefer self-assigned this Jun 17, 2022

sonatype-lift bot reviewed Jun 17, 2022

View reviewed changes

larsgrefer and others added 3 commits June 17, 2022 19:10

Set Description

7bc8ed1

some improvements

4edb338

remove default format

6d97667

larsgrefer and others added 8 commits June 17, 2022 19:21

Run plantuml in awt.headless mode

4953f73

Merge branch 'master' into feature/plantuml

4ef883c

cleanup plantuml example

063e9c9

cleanup

4cf5748

added some new unit tests

e91c91f

cleanup

6f180df

Merge branch 'feature/plantuml' of github.com:freefair/gradle-plugins…

4e52447

… into feature/plantuml

cleanup test

4a5ac9d

Frisch12 merged commit b04ff31 into master Jun 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PlantUml Plugin #551

Add PlantUml Plugin #551

larsgrefer commented Jun 17, 2022

sonatype-lift bot Jun 17, 2022

larsgrefer Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

larsgrefer Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

larsgrefer Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

larsgrefer Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

larsgrefer Jun 17, 2022

sonatype-lift bot Jun 17, 2022

codecov bot commented Jun 17, 2022 •

edited

Add PlantUml Plugin #551

Add PlantUml Plugin #551

Conversation

larsgrefer commented Jun 17, 2022

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

larsgrefer Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

larsgrefer Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

larsgrefer Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

larsgrefer Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

larsgrefer Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

codecov bot commented Jun 17, 2022 • edited

Codecov Report

codecov bot commented Jun 17, 2022 •

edited