Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ember-canary scenario/channel #141

Merged
merged 5 commits into from
May 17, 2023
Merged

Test ember-canary scenario/channel #141

merged 5 commits into from
May 17, 2023

Conversation

Panman82
Copy link
Contributor

The ember-canary test scenario was removed from the GH Workflow due to errors with the pending ember.js v5 release. I'm creating this PR so it is easy to re-test the canary channel as thing change with ember.js development.

This addon still works with those versions, but the newer `ember-qunit` does not allow lower than 3.28.
Since `canary` is moving to 5.0.0...
@Panman82
Copy link
Contributor Author

Trying to get this to pass with help on emberjs/ember.js#20418

@Panman82
Copy link
Contributor Author

Panman82 commented Apr 3, 2023

Will try again once render-modifiers allow ember v5: emberjs/ember-render-modifiers#70

EDIT: PR is merged, but waiting for a new version release.

@Panman82
Copy link
Contributor Author

Well, new version of the froala-editor necessitates a new release here, but render-modifiers has yet to release with the potential fix. So I'm just going to merge this PR with failing test, update ember to v4.12, update froala editor and release this addon... 😕

@Panman82 Panman82 marked this pull request as ready for review May 17, 2023 18:44
@Panman82 Panman82 merged commit ce7402a into master May 17, 2023
8 of 11 checks passed
@Panman82 Panman82 deleted the test-canary-channel branch May 17, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant