Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove URL from frontity exports #206

Merged
merged 1 commit into from Sep 9, 2020
Merged

Remove URL from frontity exports #206

merged 1 commit into from Sep 9, 2020

Conversation

luisherranz
Copy link
Member

We've removed support for Node 8 and therefore deprecated the URL import from "frontity". This import was the only thing we had for backward compatibility with Node 8 so it's safe to deprecate it now.

The deprecation work has been done in this PR: frontity/frontity#543

@luisherranz luisherranz added topic: packages type: code release Documentation related to a code release labels Aug 25, 2020
@luisherranz luisherranz self-assigned this Aug 25, 2020
@luisherranz
Copy link
Member Author

I've branched this out of master. I'll rebase it in code.

@luisherranz
Copy link
Member Author

Done 👍

juanmaguitar
juanmaguitar previously approved these changes Aug 25, 2020
View reviewed changes
@juanmaguitar
Copy link
Member

@luisherranz For next PR's related to Code Releases in this docs repository we simplified the process by:

  • not using the code branch
  • creating PR's directly against master
  • not merging these PR's until the release is done

https://github.com/frontity/docs/wiki/Code-Releases#documentation-changes-before-code-releases

@luisherranz
Copy link
Member Author

Oh, I didn't know. Do you want me to rebase it again onto master or we can merge this as it is?

@juanmaguitar
Copy link
Member

Oh, I didn't know. Do you want me to rebase it again onto master or we can merge this as it is?

If you don't mind I'd prefer if you rebase it again onto master as we're not using code branch anymore and I'm not sure what's in there

@luisherranz
Copy link
Member Author

Sure!

@luisherranz
Copy link
Member Author

Done 🙂

@luisherranz luisherranz changed the base branch from code to master August 25, 2020 15:54
@luisherranz luisherranz dismissed juanmaguitar’s stale review August 25, 2020 15:54

The base branch was changed.

@juanmaguitar juanmaguitar self-requested a review August 26, 2020 07:21
@juanmaguitar
Copy link
Member

@luisherranz Can this PR be merged? Do you prefer me to do it?

@luisherranz
Copy link
Member Author

Don't you wait until the next release?

@juanmaguitar
Copy link
Member

juanmaguitar commented Aug 26, 2020 •
edited

Don't you wait until the next release?

Yes.

@luisherranz luisherranz removed their assignment Aug 27, 2020
@juanmaguitar
Copy link
Member

As this code has been released according. to this → https://github.com/frontity/frontity/releases/tag/frontity%401.11.0
I'm merging these changes

@juanmaguitar juanmaguitar merged commit ff17992 into master Sep 9, 2020
@juanmaguitar juanmaguitar deleted the remove-url-from-frontity branch September 9, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmaguitar juanmaguitar juanmaguitar approved these changes

Assignees
No one assigned
Labels
status: waiting-for-release topic: packages type: code release Documentation related to a code release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luisherranz @juanmaguitar