Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #842

Closed
wants to merge 5 commits into from
Closed

Version Packages #842

wants to merge 5 commits into from

Conversation

frontibotito
Copy link
Member

@frontibotito frontibotito commented Jun 3, 2021

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@frontity/components@1.8.0

Minor Changes

  • 2f988427 #826 Thanks @michalczaplinski! - Make the Image component from @frontity/components AMP-aware and remove the Intersection Observer fallback which used to lazily load images in the absence of native lazy loading.

@frontity/core@1.14.2

Patch Changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@luisherranz
Copy link
Member

#837 is the fix that makes #834 not needed anymore 😆

I'm going to push a revert of that PR.

@luisherranz
Copy link
Member

I think that fixes it.

@SantosGuillamot
Copy link
Member

Okay, great. Thanks @luisherranz 🙂

@DAreRodz
Copy link
Member

DAreRodz commented Jun 3, 2021

The create-symlinks tests in @frontity/core were failing (see this). They were failing in my local environment as well, and I've made them pass just updating the package-lock file.

Let's see if that fixes the error.

@DAreRodz
Copy link
Member

DAreRodz commented Jun 3, 2021

Uhm, weird, I didn't fix anything... 🤔

@SantosGuillamot
Copy link
Member

Mmm, if they are passing locally, could be something related to npm? I remember we have had issues in the past because we use npm 7 and GitHub actions use npm 6.

@DAreRodz
Copy link
Member

DAreRodz commented Jun 3, 2021

Mmm, if they are passing locally, could be something related to npm? I remember we have had issues in the past because we use npm 7 and GitHub actions use npm 6.

Actually it's failing with node 16 and npm 7.

@DAreRodz
Copy link
Member

DAreRodz commented Jun 3, 2021

OK, I didn't try with those versions before. 🙈

Not it fails in my local env with a more related error: Error: write EBADF.

@luisherranz
Copy link
Member

luisherranz commented Jun 3, 2021

It doesn't seem specific to this particular PR because I just pushed to this other one and it also failed: #836

@DAreRodz
Copy link
Member

DAreRodz commented Jun 3, 2021

It doesn't seem specific to this particular PR because I just pushed to this other one and it also failed: #836

I've created a PR that seems to fix the issue: #843

@SantosGuillamot SantosGuillamot deleted the changeset-release/master branch June 4, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants