Fix typst#3826

CC: @Dherse
frozolotl · Mar 29, 2024 · 3e26a5f · 3e26a5f
1 parent d60c8f4
commit 3e26a5f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/crates/typst/src/layout/ratio.rs b/crates/typst/src/layout/ratio.rs
@@ -70,7 +70,7 @@ impl Ratio {
 
 impl Debug for Ratio {
     fn fmt(&self, f: &mut Formatter) -> fmt::Result {
-        write!(f, "{:?}%", self.get())
+        write!(f, "{:?}%", self.get() * 100.0)
     }
 }
 

diff --git a/crates/typst/src/visualize/gradient.rs b/crates/typst/src/visualize/gradient.rs
@@ -1249,7 +1249,11 @@ fn sample_stops(stops: &[(Color, Ratio)], mixing_space: ColorSpace, t: f64) -> C
 
     let (col_0, pos_0) = stops[low - 1];
     let (col_1, pos_1) = stops[low];
-    let t = (t - pos_0.get()) / (pos_1.get() - pos_0.get());
+    let mut delta = pos_1.get() - pos_0.get();
+    if delta == 0.0 {
+        delta = 1.0;
+    }
+    let t = (t - pos_0.get()) / delta;
 
     Color::mix_iter(
         [WeightedColor::new(col_0, 1.0 - t), WeightedColor::new(col_1, t)],

diff --git a/tests/ref/bugs/3826-gradient-div-zero.png b/tests/ref/bugs/3826-gradient-div-zero.png
diff --git a/tests/typ/bugs/3826-gradient-div-zero.typ b/tests/typ/bugs/3826-gradient-div-zero.typ
@@ -0,0 +1,4 @@
+// Issue #3826: Second stop at 0% in gradient crashes compiler in web app
+
+---
+#rect(width: 100%, fill: gradient.linear((red, 0%), (blue, 0%), (green, 100%)))