Update index.js #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problem with duplicate fire in Windows OS. It's about creating variable, that informs about last event. If event type and filename are equals and delay between events is smaller than 20 ms, then event ignored. Tested on Windows 8.
|
hi sorry for missing this. i'm going to add you as a collaborator and add you on npm since i'd like more maintainers as well |
| @@ -42,6 +44,9 @@ Watcher.prototype.watch = function (name, files) { | |||
| watchers[filename] = watch(filename, { | |||
| persistent: true | |||
| }, function (event) { | |||
| // Catch event clone | |||
| if (self.lastFire[0]===event[0]&&self.lastFire[1]===event[1]&&(new Date())-self.lastFire[2]<20) return; | |||
| self.lastFire=[event[0],event[1],new Date()]; | |||
There was a problem hiding this comment.
style tip: need space around operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem with duplicate fire in Windows OS. It's about creating variable, that informs about last event. If event type and filename are equals and delay between events is smaller than 20 ms, then event ignored. Tested on Windows 8.