Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back-pin eslint-plugin-react to avoid linting syntax errors #11

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Back-pin eslint-plugin-react to avoid linting syntax errors #11

merged 4 commits into from
Oct 1, 2019

Commits on Oct 1, 2019

  1. Back-pin eslint-plugin-react to avoid linting syntax errors 

    The recent release of [eslint-plugin-react#7.15.0](https://github.com/yannickcr/eslint-plugin-react/releases/tag/v7.15.0) chokes any time it runs into a property with JSX inside it ([example code](https://github.com/fs-webdev/babylon/blob/master/packages/person/src/Person.js#L391)).

Example error from babylon:

> TypeError: Cannot read property 'substring' of undefined
Occurred while linting /Users/clif/sandbox/frontier/fs-components/babylon/packages/attribution/src/Attribution.js:45
    at Object.fix (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint-plugin-react/lib/rules/jsx-curly-brace-presence.js:129:30)
    at normalizeFixes (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint/lib/util/report-translator.js:176:28)
    at args (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint/lib/util/report-translator.js:278:18)
    at Object.report (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint/lib/linter.js:721:41)
    at reportUnnecessaryCurly (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint-plugin-react/lib/rules/jsx-curly-brace-presence.js:117:15)
    at lintUnnecessaryCurly (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint-plugin-react/lib/rules/jsx-curly-brace-presence.js:198:9)
    at JSXExpressionContainer (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint-plugin-react/lib/rules/jsx-curly-brace-presence.js:278:11)
    at listeners.(anonymous function).forEach.listener (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint/lib/util/safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/clif/sandbox/frontier/fs-components/babylon/node_modules/eslint/lib/util/safe-emitter.js:45:38)
    @skye2k2
    skye2k2 committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    ac9e88c View commit details
    Browse the repository at this point in the history

  2. Update package-lock

    @redbugz
    redbugz committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    323086f View commit details
    Browse the repository at this point in the history

  3. Fix security alerts

    @redbugz
    redbugz committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    03deaa7 View commit details
    Browse the repository at this point in the history

  4. Skip double Travis build on PRs

    @redbugz
    redbugz committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    46afae0 View commit details
    Browse the repository at this point in the history