Hw12 harb #141
Merged
Hw12 harb #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/graphql/mutations/create_task.rb
Outdated
Comment on lines
4
to
5
| argument :input, Types::Inputs::CreateTaskInput, required: true | ||
| argument :project_id, ID, required: true |
There was a problem hiding this comment.
If you have input, please pass project_id in input too
There was a problem hiding this comment.
And in all others mutations
| @@ -0,0 +1,14 @@ | |||
| module Mutations | |||
| class DestroyProject < BaseMutation | |||
| argument :input, Types::Inputs::DestroyProjectInput, required: true | |||
There was a problem hiding this comment.
In this case, you can use just argument :id, ID, required: true
app/graphql/mutations/create_task.rb
Outdated
| type Types::Payloads::TaskPayload | ||
|
|
||
| def resolve(input:, project_id:) | ||
| @project = Project.find(project_id) |
There was a problem hiding this comment.
Why you needed instance variable here?
Suggested change
| @project = Project.find(project_id) | |
| project = Project.find(project_id) |
| argument :id, ID, required: true | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Please add an empty line in the end of file
|
Also please resolve conflicts |
There was a problem hiding this comment.
You just need id here, and you can take task by id, and project by task
Comment on lines
9
to
10
| @task = Task.find(input.id) | ||
| @project = Project.find(input.project_id) |
There was a problem hiding this comment.
You don't need instance variable
Suggested change
| @task = Task.find(input.id) | |
| @project = Project.find(input.project_id) | |
| task = Task.find(input.id) | |
| project = Project.find(input.project_id) |
|
Resolve conflicts and my comments please |
|
Принято! Не забывай про Rubocop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutations :
Destroy project
Create task
Destroy task
Type :
Comment