fix concurrency in init code, fixes #163 #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caches and prefers existing .junest/etc/passwd and group files before this fix it was possible that concurrent startup (as in multiple junest processes) lead to partial files for some of the junest processes.
joernhees
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches and prefers existing .junest/etc/passwd and group files
Before this fix it was possible that concurrent startup (as in multiple junest processes) lead to partial files for some of the junest processes.
This is a quick fix removing the bug and speeding up startup. There are however a couple of issues that more experienced junest members should look into:
passwdandgroupinfo change. This will however not happen on each normal junest user startup, which is the rational for my fix. It might however be desirable to allow a user to manually reset such caches. Docs should point out that such calls shouldn't be parallelized though.