fix: proper naming for esm

[ffMathy]

This fixes a bug where node ESM code does not recognize it as ESM in Jest (and possibly ESM node applications too), because the file extension is not .mjs.

I see this has already been fixed for "cjs". This just does it for "mjs" as well. Confimed working.

• I have added automatic tests where applicable
• The PR title is suitable as a release note
• The PR contains a description of what has been changed
• The description contains manual test instructions

Changes

Test

[jimmycallin]

are you sure this is correct? the vite config specifies output for es modules as having .js

i believe this is rather an issue with jest, and their lacking support of es modules jestjs/jest#9430 this was the main driver for us to switch to vitest

[ffMathy]

What I did to verify was to change the dist file locally in my own node-modules of the ftrack widget to be called .mjs instead of es.js.

FtrackWidget was the only package not working out of approximately 1800 of our packages for ESM in Jest. It gave an error saying "export" was not defined.

We just followed https://jestjs.io/docs/ecmascript-modules

In there, as of Node 20, ESM is working just fine (although through an experimental flag).

Although because I only verified it in the dist folder directly by modifying that locally, I didn't catch the build config change needed to. I'll update that.

[ffMathy]

I update the config now. Thanks for catching that.

[ffMathy]

@ftrack__web-widget@1.6.4.patch

Here's a patch file that made Jest work in our environment.

[jimmycallin]

@ftrack__web-widget@1.6.4.patch

Here's a patch file that made Jest work in our environment.

is there a reason you provide the PR for this repository and not https://github.com/ftrackhq/ftrack-web-widget ?

[ffMathy]

Ooooh, I got it mixed up - my bad. I thought this was a kind of monorepo containing both 🤦

Will make it over there and close this.