-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot-shared-folder #984
base: master
Are you sure you want to change the base?
Conversation
155bf4e
to
ebd096e
Compare
What shall we do with this PR @c-git ? |
Sure, I don't recall what we'd decided. I'll have to try to lookup the chat. |
By any chance do you recall? |
Documenting the next planned steps
|
d96f846
to
8ed3000
Compare
Closed by rebase, will reopen once I have a commit I want. Just trying to finalize what to do in my head. Trying to read the current code to get context. |
I can merge it at the end instead of modify the same files multiple times but for now wanted to start from closer to the target structure. |
360a915
to
97b6e2e
Compare
Ok done. Didn't document how to accept the new snapshots when the time comes but I don't know where would be a good place to do that, contributors guide? I included a string version of the input before removing white space you'll let me know if it makes sense. |
crates/trippy/tests/resources/snapshots/trip__config__tests__compare_snapshot@trip --help.snap
Outdated
Show resolved
Hide resolved
crates/trippy/tests/resources/snapshots/trip__config__tests__compare_snapshot@trip -h.snap
Outdated
Show resolved
Hide resolved
97b6e2e
to
53ea414
Compare
53ea414
to
154257b
Compare
154257b
to
97b6e2e
Compare
97b6e2e
to
154257b
Compare
Matching format of tests structure for trippy-core
154257b
to
325268f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks good to me.
Replace the snapshots manually managed over to insta for management
using the tool
We can choose to put the snapshot files anywhere we want so where the files are is not an issue. Only issue we need to contend with is white space and what appears to be screen with issues between local and CI.