Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot-shared-folder #984

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Snapshot-shared-folder #984

wants to merge 3 commits into from

Conversation

c-git
Copy link
Collaborator

@c-git c-git commented Feb 4, 2024

Replace the snapshots manually managed over to insta for management
using the tool

We can choose to put the snapshot files anywhere we want so where the files are is not an issue. Only issue we need to contend with is white space and what appears to be screen with issues between local and CI.

@c-git c-git mentioned this pull request Feb 4, 2024
@c-git c-git force-pushed the snapshot-shared-folder branch 7 times, most recently from 155bf4e to ebd096e Compare February 4, 2024 21:25
@fujiapple852
Copy link
Owner

What shall we do with this PR @c-git ?

@c-git
Copy link
Collaborator Author

c-git commented Apr 10, 2024

Sure, I don't recall what we'd decided. I'll have to try to lookup the chat.

@c-git
Copy link
Collaborator Author

c-git commented Apr 10, 2024

By any chance do you recall?

@c-git
Copy link
Collaborator Author

c-git commented May 5, 2024

Documenting the next planned steps

  • Rebase branch to onto main
  • Clear out old work done on this
  • Remove the current baseline files and replace them with snapshots (hopefully they will be similar as we'll also be removing the whitespace so it will look like a file rename and not a delete and add).
  • Test and document update process (where should it be documented?)

@c-git c-git closed this May 20, 2024
@c-git c-git deleted the snapshot-shared-folder branch May 20, 2024 22:31
@c-git c-git restored the snapshot-shared-folder branch May 20, 2024 22:32
@c-git
Copy link
Collaborator Author

c-git commented May 20, 2024

Closed by rebase, will reopen once I have a commit I want. Just trying to finalize what to do in my head. Trying to read the current code to get context.

@c-git
Copy link
Collaborator Author

c-git commented May 20, 2024

I can merge it at the end instead of modify the same files multiple times but for now wanted to start from closer to the target structure.

@c-git c-git reopened this May 20, 2024
@c-git c-git force-pushed the snapshot-shared-folder branch 2 times, most recently from 360a915 to 97b6e2e Compare May 21, 2024 14:43
@c-git c-git marked this pull request as ready for review May 21, 2024 14:44
@c-git
Copy link
Collaborator Author

c-git commented May 21, 2024

Ok done. Didn't document how to accept the new snapshots when the time comes but I don't know where would be a good place to do that, contributors guide?

I included a string version of the input before removing white space you'll let me know if it makes sense.

Copy link
Collaborator Author

@c-git c-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good to me.

crates/trippy/src/main.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants