Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packaging): Disable compiling library with ivy #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AncelHernandez
Copy link

@AncelHernandez AncelHernandez commented May 28, 2020

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: #163

There is a build error when compiling an application with this library:

ERROR: Error during template compile of 'CoreModule'
  Function calls are not supported in decorators but 'ConfigModule' was called.

** What is the new behavior?
No build error. It is not recomended for libraries to be compiled with ivy yet.

Per the CLI:

It is not recommended to publish Ivy libraries to NPM repositories.
Read more here: https://v9.angular.io/guide/ivy#maintaining-library-compatibility

** Does this PR introduce a breaking change?

[ ] Yes
[ x] No

** Other information

@ghost
Copy link

ghost commented May 28, 2020

Warnings are found on analyzing the commit a87acc8.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files           9        9           
  Lines          91       91           
  Branches       12        9    -3     
=======================================
  Hits           87       87           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5786b9a...a87acc8. Read the comment docs.

@fulls1z3
Copy link
Owner

fulls1z3 commented Jul 8, 2021

@AncelHernandez need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants